Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check code builds with gcc v14 #446

Merged
merged 3 commits into from
Sep 16, 2024
Merged

CI: Check code builds with gcc v14 #446

merged 3 commits into from
Sep 16, 2024

Conversation

alexdewar
Copy link
Contributor

@alexdewar alexdewar commented Jun 17, 2024

I finally made this work by updating the runners to the latest Ubuntu LTS release (24.04). Happily, this release includes a g++-14 package, so we no longer have to rely on a PPA.

We will have to update the branch protection rules before this can be merged.

Closes #413.

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What's up with the branch protection rules?

@alexdewar
Copy link
Contributor Author

The branch protection rules need updating because the names of the checks have changed due to the runner version changing.

@alexdewar
Copy link
Contributor Author

I've updated them now, so any open PRs will need to merge main (once this branch is merged)

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.93%. Comparing base (735f15a) to head (3e1931e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   46.17%   48.93%   +2.75%     
==========================================
  Files         160      162       +2     
  Lines        7787     7761      -26     
  Branches     1054     1054              
==========================================
+ Hits         3596     3798     +202     
+ Misses       4005     3954      -51     
+ Partials      186        9     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdewar alexdewar merged commit b5c86cf into main Sep 16, 2024
7 checks passed
@alexdewar alexdewar deleted the ci_gcc14 branch September 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Bump version of gcc to use to 14
2 participants