CI: Check code builds with gcc v14 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
force-pushed
the
ci_gcc14
branch
2 times, most recently
from
2e0a7d0
to
a3906f0
Compare
jamesturner246
approved these changes
Sep 13, 2024
|
The branch protection rules need updating because the names of the checks have changed due to the runner version changing. |
|
I've updated them now, so any open PRs will need to merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 46.17% 48.93% +2.75%
==========================================
Files 160 162 +2
Lines 7787 7761 -26
Branches 1054 1054
==========================================
+ Hits 3596 3798 +202
+ Misses 4005 3954 -51
+ Partials 186 9 -177 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally made this work by updating the runners to the latest Ubuntu LTS release (24.04). Happily, this release includes a
g++-14package, so we no longer have to rely on a PPA.We will have to update the branch protection rules before this can be merged.
Closes #413.